Issue 342019: Add binary operations to fast compiler.

Issue 342019: Add binary operations to fast compiler. (Closed)

Created:
11 years, 1 month ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add binary operations to fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3172

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -31 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View	1	3 chunks	+56 lines, -6 lines	0 comments	Download
M	src/compiler.cc	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	src/fast-codegen.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/fast-codegen-ia32.cc	View	1	3 chunks	+68 lines, -13 lines	0 comments	Download
M	src/x64/fast-codegen-x64.cc	View	1	4 chunks	+69 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

Cute. Couple of comments need to be updated in each platform-specific backend file. LGTM. http://codereview.chromium.org/342019/diff/1/4 ...

11 years, 1 month ago (2009-10-28 15:34:06 UTC) #2

William Hesse

11 years, 1 month ago (2009-10-29 11:39:52 UTC) #3

http://codereview.chromium.org/342019/diff/1/4
File src/compiler.cc (right):

http://codereview.chromium.org/342019/diff/1/4#newcode855
Line 855: Visit(expr->right());
On 2009/10/28 15:34:07, Kevin Millikin wrote:
> Should have a comment wherever we intentionally call plain Visit in order to
> inherit the parent context.

Done.

http://codereview.chromium.org/342019/diff/1/2
File src/fast-codegen.h (right):

http://codereview.chromium.org/342019/diff/1/2#newcode81
Line 81: void LogicalOperation(BinaryOperation* expr);
On 2009/10/28 15:34:07, Kevin Millikin wrote:
> GenerateLogicalOperation?  EmitLogicalOperation?

Done.

http://codereview.chromium.org/342019/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/342019/diff/1/3#newcode619
Line 619: // Compile a short-circuited boolean or operation in a non-test
On 2009/10/28 15:34:07, Kevin Millikin wrote:
> Update comment.

Done.

http://codereview.chromium.org/342019/diff/1/3#newcode669
Line 669: // (let (temp = e0) temp ? temp : e1).
On 2009/10/28 15:34:07, Kevin Millikin wrote:
> Update comment.

Done.

Expand Messages | Collapse Messages