chrome_frame/chrome_frame_automation.cc - Issue 342018: Remove a DCHECK that happens on every exit of IE. We appear to be leaking aut...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/chrome_frame_automation.cc

Issue 342018: Remove a DCHECK that happens on every exit of IE. We appear to be leaking aut... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/chrome_frame_automation.cc

===================================================================

--- chrome_frame/chrome_frame_automation.cc (revision 30332)

+++ chrome_frame/chrome_frame_automation.cc (working copy)

@@ -164,7 +164,12 @@

}

ProxyFactory::~ProxyFactory() {

- DCHECK_EQ(proxies_.container().size(), 0);

+ for (size_t i = 0; i < proxies_.container().size(); ++i) {

+ if (WAIT_OBJECT_0 !=

+ WaitForSingleObject(proxies_[i]->thread->thread_handle(), 0))

+ // TODO(stoyan): Don't leak proxies on exit.

+ DLOG(ERROR) << "Proxies leaked on exit.";

+ }

}

void* ProxyFactory::GetAutomationServer(int launch_timeout,

« no previous file with comments | « no previous file | no next file » | no next file with comments »