Limit chrome.(browser|page)Action.setIcon({imageData:...}) to a

chrome/renderer/resources/extension_process_bindings.js

 // Copyright (c) 2009 The chrome Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
@@ skipping 329 matching lines @@
       return tabIdProxy;
     }
 
     apiFunctions["i18n.getMessage"].handleRequest =
         function(message_name, placeholders) {
       return GetL10nMessage(message_name, placeholders);
     }
 
     var canvas;
     function setIconCommon(details, name, parameters) {
+      var EXTENSION_ACTION_SIZE = 19;

[Finnur, 2009/10/28 04:49:01]

nit: EXTENSION_ACTION_IMAGE_SIZE (extension action is more than an icon). :)

+
       if ("iconIndex" in details) {
         sendRequest(name, [details], parameters);
       } else if ("imageData" in details) {
         // Verify that this at least looks like an ImageData element.
         // Unfortunately, we cannot use instanceof because the ImageData
         // constructor is not public.
         //
         // We do this manually instead of using JSONSchema to avoid having these
         // properties show up in the doc.
         if (!("width" in details.imageData) ||
             !("height" in details.imageData) ||
             !("data" in details.imageData)) {
           throw new Error(
               "The imageData property must contain an ImageData object.");
         }
+
+        if (details.imageData.width > EXTENSION_ACTION_SIZE ||
+            details.imageData.height > EXTENSION_ACTION_SIZE) {
+          throw new Error(
+              "The imageData property must contain an ImageData object that " +
+              "is no larger than 19 pixels square.");
+        }
+
         sendCustomRequest(SetExtensionActionIcon, name, [details], parameters);
       } else if ("path" in details) {
         var img = new Image();
         img.onerror = function() {
           console.error("Could not load browser action icon '" + details.path +
                         "'.");
         }
         img.onload = function() {
           var canvas = document.createElement("canvas");
-          canvas.width = img.width > 19 ? 19 : img.width;
-          canvas.height = img.height > 19 ? 19 : img.height;
+          canvas.width = img.width > EXTENSION_ACTION_SIZE ?
+              EXTENSION_ACTION_SIZE : img.width;
+          canvas.height = img.height > EXTENSION_ACTION_SIZE ?
+              EXTENSION_ACTION_SIZE : img.height;
 
           var canvas_context = canvas.getContext('2d');
           canvas_context.clearRect(0, 0, canvas.width, canvas.height);
           canvas_context.drawImage(img, 0, 0, canvas.width, canvas.height);
           delete details.path;
           details.imageData = canvas_context.getImageData(0, 0, canvas.width,
                                                           canvas.height);
           sendCustomRequest(SetExtensionActionIcon, name, [details], parameters);
         }
         img.src = details.path;
       } else {
         throw new Error(
             "Either the path or imageData property must be specified.");
       }
     }
 
     apiFunctions["browserAction.setIcon"].handleRequest = function(details) {
       setIconCommon(details, this.name, this.definition.parameters);
     };
 
     apiFunctions["pageAction.setIcon"].handleRequest = function(details) {
       setIconCommon(details, this.name, this.definition.parameters);
     };
 
     setupBrowserActionEvent(extensionId);
     setupPageActionEvents(extensionId);
     setupToolstripEvents(GetRenderViewId());
   });
 })();