Issue 342012: Limit chrome.(browser|page)Action.setIcon({imageData:...}) to a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342012: Limit chrome.(browser|page)Action.setIcon({imageData:...}) to a (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Limit chrome.(browser|page)Action.setIcon({imageData:...}) to a max of 19px square. BUG=25626 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30327

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	chrome/renderer/resources/extension_process_bindings.js	View		3 chunks	+14 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

11 years, 1 month ago (2009-10-28 04:49:01 UTC) #2

LGTM, one nit (below).

There is a unit test crash on Mac on the try bot. I presume it is unrelated?

http://codereview.chromium.org/342012/diff/1/2
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/342012/diff/1/2#newcode350
Line 350: var EXTENSION_ACTION_SIZE = 19;
nit: EXTENSION_ACTION_IMAGE_SIZE (extension action is more than an icon). :)

Expand Messages | Collapse Messages