Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 342006: Rebaseline LayoutTests/editing/execCommand/indent-paragraphs.html, which was (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Rebaseline LayoutTests/editing/execCommand/indent-paragraphs.html, which was added by the merge. There's no pixel checked in upstream, but we match except for not showing image placeholders. The test has the following images: <img src="http://"> With GURL, the URL is rejected and it doesn't try to load the image. In KURL, the URL is "valid", but it fails to load an image so the place holder image is shown instead. Since that's not what the test is trying to test, just rebaseline. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -5 lines) Patch
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/indent-paragraphs-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/indent-paragraphs-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/indent-paragraphs-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/indent-paragraphs-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/indent-paragraphs-expected.txt View 1 chunk +68 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-paragraphs-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-paragraphs-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-paragraphs-expected.txt View 1 chunk +67 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 1 month ago (2009-10-27 22:41:00 UTC) #1
ojan
11 years, 1 month ago (2009-10-27 23:00:38 UTC) #2
LGTM.

It's strange to me that we treat an invalid URL differently than a 404ing URL
though. It seems like both should show the placeholder image. Maybe file a bug
for that?

Powered by Google App Engine
This is Rietveld 408576698