Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/dom_ui/advanced_options_handler.h

Issue 3419020: dom-ui settings: properly implement the 'metrics reporting' checkbox.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r60664. Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/dom_ui/advanced_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/advanced_options_handler.h
===================================================================
--- chrome/browser/dom_ui/advanced_options_handler.h (revision 60664)
+++ chrome/browser/dom_ui/advanced_options_handler.h (working copy)
@@ -50,6 +50,9 @@
// they want to reset all options to their default values.
void HandleResetToDefaults(const ListValue* args);
+ // Callback for the "metricsReportingCheckboxAction" message. This is called
+ // if the user toggles the metrics reporting checkbox.
+ void HandleMetricsReportingCheckbox(const ListValue* args);
#if defined(OS_WIN)
// Callback for the "Check SSL Revocation" checkbox. This is needed so we
// can support manual handling on Windows.
@@ -73,6 +76,9 @@
void ShowManageSSLCertificates(const ListValue* args);
#endif
+ // Setup the checked state for the metrics reporting checkbox.
+ void SetupMetricsReportingCheckbox(bool user_changed);
+
// Setup the download path based on user preferences.
void SetupDownloadLocationPath();
@@ -83,11 +89,12 @@
void SetupProxySettingsSection();
#if defined(OS_WIN)
- // Setup the checked state SSL related checkboxes.
+ // Setup the checked state for SSL related checkboxes.
void SetupSSLConfigSettings();
#endif
scoped_refptr<SelectFileDialog> select_folder_dialog_;
+ BooleanPrefMember enable_metrics_recording_;
FilePathPrefMember default_download_location_;
StringPrefMember auto_open_files_;
scoped_ptr<PrefSetObserver> proxy_prefs_;
« no previous file with comments | « no previous file | chrome/browser/dom_ui/advanced_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698