dom-ui settings: properly implement the 'metrics reporting' checkbox....

chrome/browser/resources/options/advanced_options.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
 var OptionsPage = options.OptionsPage;
 
   //
   // AdvancedOptions class
   // Encapsulated handling of advanced options page.
   //
   function AdvancedOptions() {
     OptionsPage.call(this, 'advanced', templateData.advancedPage,
                      'advancedPage');
   }
 
   cr.addSingletonGetter(AdvancedOptions);
 
   AdvancedOptions.prototype = {
     // Inherit AdvancedOptions from OptionsPage.
     __proto__: options.OptionsPage.prototype,
 
-    // Initialize AdvancedOptions page.
+    /**
+     * Initializes the page.
+     */
     initializePage: function() {
       // Call base class implementation to starts preference initialization.
       OptionsPage.prototype.initializePage.call(this);
 
       // Setup click handlers for buttons.
       $('privacyContentSettingsButton').onclick = function(event) {
         OptionsPage.showPageByName('content');
         OptionsPage.showTab($('cookies-nav-tab'));
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ContentSettings']);
       };
       $('privacyClearDataButton').onclick = function(event) {
         OptionsPage.showOverlay('clearBrowserDataOverlay');
         chrome.send('coreOptionsUserMetricsAction', ['Options_ClearData']);
       };
+      // 'metricsReportingEnabled' element is only present on Chrome branded
+      // builds.
+      if ($('metricsReportingEnabled')) {
+        $('metricsReportingEnabled').onclick = function(event) {
+          chrome.send('metricsReportingCheckboxAction',
+              [String(event.target.checked)]);
+        };
+      }
       $('autoOpenFileTypesResetToDefault').onclick = function(event) {
         chrome.send('autoOpenFileTypesAction');
       };
       $('fontSettingsConfigureFontsOnlyButton').onclick = function(event) {
         OptionsPage.showPageByName('fontSettings');
         chrome.send('coreOptionsUserMetricsAction', ['Options_FontSettings']);
       };
       if (!cr.isChromeOS) {
         $('optionsReset').onclick = function(event) {
           AlertOverlay.show(undefined,
@@ skipping 32 matching lines @@
               [String($('sslCheckRevocation').checked)]);
         };
         $('sslUseSSL2').onclick = function(event) {
           chrome.send('useSSL2CheckboxAction',
               [String($('sslUseSSL2').checked)]);
         };
         $('gearSettingsConfigureGearsButton').onclick = function(event) {
           chrome.send('showGearsSettings');
         };
       }
+    },
+
+    /**
+     * Show a 'restart required' alert.
+     * @private
+     */
+    showRestartRequiredAlert_: function() {
+      AlertOverlay.show(undefined,
+          localStrings.getString('optionsRestartRequired'),
+          undefined, '', undefined);
     }
   };
 
   //
   // Chrome callbacks
   //
 
+  // Set the checked state of the metrics reporting checkbox.
+  AdvancedOptions.SetMetricsReportingCheckboxState = function(checked,
+      disabled, user_changed) {
+    $('metricsReportingEnabled').checked = checked;
+    $('metricsReportingEnabled').disabled = disabled;
+
+    if (user_changed)
+      AdvancedOptions.getInstance().showRestartRequiredAlert_();
+  }
+
   // Set the download path.
   AdvancedOptions.SetDownloadLocationPath = function(path) {
     if (!cr.isChromeOS)
       $('downloadLocationPath').value = path;
   };
 
   // Set the enabled state for the autoOpenFileTypesResetToDefault button.
   AdvancedOptions.SetAutoOpenFileTypesDisabledAttribute = function(disabled) {
     $('autoOpenFileTypesResetToDefault').disabled = disabled;
   };
@@ skipping 13 matching lines @@
   AdvancedOptions.SetUseSSL2CheckboxState = function(checked) {
     $('sslUseSSL2').checked = checked;
   };
 
   // Export
   return {
     AdvancedOptions: AdvancedOptions
   };
 
 });