Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 3419018: AU: Switch from SHA-1 to SHA-256 hash. (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr, kthanasi_chromium.org, krisr
Visibility:
Public.

Description

AU: Switch from SHA-1 to SHA-256 hash. For hashing of images, expect a new "sha256" attribute in Omaha's updatecheck response. BUG=6580 TEST=unit tests, gmerged on device and updated with upgraded dev server Change-Id: I122e21cd7edc74695cb81b2eee5ce70f152f5270 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d22cb29

Patch Set 1 #

Patch Set 2 : remove trailing whitespace #

Patch Set 3 : update unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M omaha_hash_calculator.h View 1 chunk +1 line, -1 line 0 comments Download
M omaha_hash_calculator.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M omaha_hash_calculator_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M omaha_request_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M omaha_request_action_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M payload_signer.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M payload_signer_unittest.cc View 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 2 months ago (2010-09-23 19:31:53 UTC) #1
adlr
10 years, 2 months ago (2010-09-23 20:28:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698