Issue 3419014: Add persist option to vm library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3419014: Add persist option to vm library. (Closed)

Created:
10 years, 3 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Add persist option to vm library. BUG= TEST=Tested by persisting, ctrl+c, continuing and using same vm. Also without --persist Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8f6ee51

Patch Set 1 #

Patch Set 2 : Move persist flag to lib #

Patch Set 3 : Somehow git was skipping lib #

Total comments: 8

Patch Set 4 : Fix nits #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -0 lines)			Patch
	M	bin/cros_run_vm_update	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	A	lib/cros_vm_lib.sh	View	3	1 chunk	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

Consider removing the flags from the library and making them function arguments. LGTM with some ...

10 years, 3 months ago (2010-09-22 17:39:41 UTC) #2

sosa

10 years, 3 months ago (2010-09-22 17:47:15 UTC) #3

Fixed nits, committing.

http://codereview.chromium.org/3419014/diff/4001/5002
File lib/cros_vm_lib.sh (right):

http://codereview.chromium.org/3419014/diff/4001/5002#newcode11
lib/cros_vm_lib.sh:11: DEFINE_integer ssh_port 9222 "Port to tunnel ssh traffic
over."
On 2010/09/22 17:39:41, petkov wrote:
> move after snapshot to keep sorted
> 

Done.

http://codereview.chromium.org/3419014/diff/4001/5002#newcode23
lib/cros_vm_lib.sh:23: function start_kvm {
On 2010/09/22 17:39:41, petkov wrote:
> add () for consistency.
> 

Done.

http://codereview.chromium.org/3419014/diff/4001/5002#newcode33
lib/cros_vm_lib.sh:33: echo "File ${KVM_PID_FILE} exists but specified pid
doesn't."
On 2010/09/22 17:39:41, petkov wrote:
> die?
> 

I don't want to necessarily assume common was sourced before this.

http://codereview.chromium.org/3419014/diff/4001/5002#newcode61
lib/cros_vm_lib.sh:61: function stop_kvm {
On 2010/09/22 17:39:41, petkov wrote:
> add ()
> 

Done.

Expand Messages | Collapse Messages