Issue 3418035: Use intptr_t instead of int for heap sizes. This is a step towards...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3418035: Use intptr_t instead of int for heap sizes. This is a step towards... (Closed)

Created:
10 years, 2 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Use intptr_t instead of int for heap sizes. This is a step towards removing the 1Gbyte limit. Committed: http://code.google.com/p/v8/source/detail?r=5542

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -98 lines)			Patch
M	src/flag-definitions.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1 2 3	8 chunks	+14 lines, -14 lines	0 comments	Download
M	src/heap.cc	View	1 2 3	14 chunks	+53 lines, -33 lines	0 comments	Download
M	src/spaces.h	View	1 2 3	17 chunks	+41 lines, -37 lines	0 comments	Download
M	src/spaces.cc	View	1 2	8 chunks	+17 lines, -10 lines	0 comments	Download
M	test/mjsunit/math-abs.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-floor.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Chromium)

10 years, 2 months ago (2010-09-28 10:30:02 UTC) #3

LGTM with lint errors fixed.

also consider making single define for 

"%" V8_PTR_PREFIX "d"