Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 3417001: Fixed stateful update in image_to_live. (Closed)

Created:
10 years, 3 months ago by DaleCurtis
Modified:
9 years, 7 months ago
Reviewers:
ericli, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

image_to_live was not providing a URL to the stateful_update script executed on the remote machine. Without the URL, stateful_update would default to reading /mnt/stateful_partition/etc/lsb-release for the URL, which is not setup by the script. I've modified image_to_live to convert the dev server url into the proper form to access the stateful.image.gz and pass it along to stateful_update on the remote system. Change-Id: I77971c83b7efef5f053fda7fcd2585ca73f3134a BUG=6705 TEST=Imaged several machines using Dev Server.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review fixes. #

Total comments: 3

Patch Set 3 : Change stateful URL based on FLAGS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M image_to_live.sh View 1 2 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
DaleCurtis
PTAL
10 years, 3 months ago (2010-09-14 03:13:21 UTC) #1
ericli
LGTM with nit. http://codereview.chromium.org/3417001/diff/1/2 File image_to_live.sh (right): http://codereview.chromium.org/3417001/diff/1/2#newcode73 image_to_live.sh:73: local stateful_url=$(echo $dev_url | sed -e ...
10 years, 3 months ago (2010-09-14 03:44:41 UTC) #2
DaleCurtis
http://codereview.chromium.org/3417001/diff/1/2 File image_to_live.sh (right): http://codereview.chromium.org/3417001/diff/1/2#newcode73 image_to_live.sh:73: local stateful_url=$(echo $dev_url | sed -e "s/update/static\/archive/") On 2010/09/14 ...
10 years, 3 months ago (2010-09-14 17:28:46 UTC) #3
ericli
LGTM.
10 years, 3 months ago (2010-09-14 17:31:39 UTC) #4
sosa
http://codereview.chromium.org/3417001/diff/3002/5001 File image_to_live.sh (right): http://codereview.chromium.org/3417001/diff/3002/5001#newcode73 image_to_live.sh:73: local stateful_url=$(echo ${dev_url} | sed -e "s/update/static\/archive/") static/archive isn't ...
10 years, 3 months ago (2010-09-14 17:55:07 UTC) #5
sosa
http://codereview.chromium.org/3417001/diff/3002/5001 File image_to_live.sh (right): http://codereview.chromium.org/3417001/diff/3002/5001#newcode73 image_to_live.sh:73: local stateful_url=$(echo ${dev_url} | sed -e "s/update/static\/archive/") Talking to ...
10 years, 3 months ago (2010-09-14 18:29:30 UTC) #6
DaleCurtis
PTAL. http://codereview.chromium.org/3417001/diff/3002/5001 File image_to_live.sh (right): http://codereview.chromium.org/3417001/diff/3002/5001#newcode73 image_to_live.sh:73: local stateful_url=$(echo ${dev_url} | sed -e "s/update/static\/archive/") On ...
10 years, 3 months ago (2010-09-14 19:49:40 UTC) #7
sosa
10 years, 3 months ago (2010-09-14 19:56:39 UTC) #8
LGTM, thx

Powered by Google App Engine
This is Rietveld 408576698