Issue 3416029: Suppress NotificationService reliability crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3416029: Suppress NotificationService reliability crashes. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
kinuko, Lei Zhang, gavinp

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Suppress NotificationService reliability crashes. BUG=57041 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60655

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/test/data/reliability/known_crashes.txt	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

10 years, 2 months ago (2010-09-30 01:54:45 UTC) #3

http://codereview.chromium.org/3416029/diff/1/2
File chrome/test/data/reliability/known_crashes.txt (right):

http://codereview.chromium.org/3416029/diff/1/2#newcode86
chrome/test/data/reliability/known_crashes.txt:86: PREFIX: `anonymous
namespace'::invalidparameter____purecall___notificationservice::notify
I think this one is too generic. There's lots of different signatures that all
end up crashing in notify(). i.e.


`anonymous namespace'::invalidparameter____purecall___`anonymous
namespace'::do_free_with_callback___notificationservice::notify___browserlist::removebrowser___browser::~browser___browser::`scalar
deleting destructor'___browserview::~browserview___browserview::`scalar deleting
destructor'___views::view::~view___views::nonclientview::`scalar deleting
destructor'___views::view::doremovechildview___views::view::removeallchildviews___views::rootview::~rootview___views::rootview::`scalar
deleting destructor'___views::widgetwin::~widgetwin___browserframewin::`scalar
deleting
destructor'___views::windowwin::onfinalmessage___views::widgetwin::onwndproc___gfx::windowimpl::wndproc___views::widgetwin::closenow___messageloop::runtask___messageloop::dowork___base::messagepumpforui::dorunloop___base::messagepumpwin::runwithdispatcher___messageloop::runinternal___messageloopforui::run___`anonymous
namespace'::runuimessageloop___browsermain___chromemain___maindllloader::launch___wwinmain_____tmaincrtstartup

is a different crash from:


`anonymous
namespace'::invalidparameter____purecall___notificationservice::current___lockimpl::unlock___`anonymous
namespace'::rolloverprotectednow___base::timeticks::now___renderviewhost::onmsgupdatetitle___histogram::sampleset::accumulate___browserrenderprocesshost::onmessagereceived___messageloop::runtask___base::messagepumpforui::dorunloop___messageloop::runinternal___messageloopforui::run___`anonymous
namespace'::runuimessageloop___browsermain___chromemain___maindllloader::launch___wwinmain_____tmaincrtstartup

Expand Messages | Collapse Messages