Issue 3416015: Adds Winsock service providers to log dumps...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3416015: Adds Winsock service providers to log dumps... (Closed)

Created:
10 years, 3 months ago by mmenke

Modified:
9 years, 7 months ago

Reviewers:
eroman, willchan no longer on Chromium

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds Winsock service providers to log dumps, and converts a couple of their numeric values to strings. Also adds the OS version from the user-agent string to the top of the log dump. TEST=manual BUG=53474 BUG=54302 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60175

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -30 lines)			Patch
M	chrome/browser/resources/net_internals/dataview.js	View		2 chunks	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/serviceprovidersview.js	View	1	3 chunks	+70 lines, -30 lines	0 comments	Download
M	chrome/browser/resources/net_internals/util.js	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

10 years, 3 months ago (2010-09-21 20:55:54 UTC) #3

lgtm

http://codereview.chromium.org/3416015/diff/4001/5002
File chrome/browser/resources/net_internals/serviceprovidersview.js (right):

http://codereview.chromium.org/3416015/diff/4001/5002#newcode47
chrome/browser/resources/net_internals/serviceprovidersview.js:47: else if
(serviceProvider.chain_length == 1)
style-nit: don't use "else" when the previous clause did a return.

if (...)
  return ...
if (...)
  return ...
return ...

http://codereview.chromium.org/3416015/diff/4001/5003
File chrome/browser/resources/net_internals/util.js (right):

http://codereview.chromium.org/3416015/diff/4001/5003#newcode115
chrome/browser/resources/net_internals/util.js:115: if (value)
The assumption here is that the value is not "false" (0, null, undefined, "",
etc..).

It would be more correct to do something like:

if (key in map)
  return map[key]

Expand Messages | Collapse Messages