Issue 3416010: Make preparsing data reusable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3416010: Make preparsing data reusable. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

Make preparsing data reusable. Fix bug in writing symbol ids over 128.

Patch Set 1 #

Total comments: 3

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	src/parser.h	View		2 chunks	+1 line, -6 lines	0 comments	Download
	M	src/parser.cc	View		3 chunks	+5 lines, -1 line	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/3416010/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3416010/diff/1/2#newcode1507 src/parser.cc:1507: Delete extra blank line http://codereview.chromium.org/3416010/diff/1/2#newcode5497 src/parser.cc:5497: // Resets ...

10 years, 3 months ago (2010-09-17 12:53:24 UTC) #3

Lasse Reichstein

10 years, 3 months ago (2010-09-17 12:55:13 UTC) #4

http://codereview.chromium.org/3416010/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/3416010/diff/1/2#newcode5497
src/parser.cc:5497: // Resets pointers to initial value, if reusing a pre-used
ScriptData.
Reworded to "Prepares script data for reading."

Expand Messages | Collapse Messages