Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 3415019: Even if HTTPError subclasses URLError, it doesn't have the member reason. (Closed)

Created:
10 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Even if HTTPError subclasses URLError, it doesn't have the member reason. That's so pythonic. Use str() instead. TBR=bradnelson TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gcl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 3 months ago (2010-09-22 20:01:48 UTC) #1
bradn
10 years, 3 months ago (2010-09-22 20:02:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698