Change the default SOCKS version used by gnome settings (and environment vari...

Change the default SOCKS version used by gnome settings (and environment variables) to be 5 instead of 4.

BUG=56833
TEST=Open Chrome in gnome. Go to change the proxy settings (which will pop open the gnome network settings). Enter as socks proxy server, "localhost:8080". Now load chrome://net-internals/#proxy and verify that it says the proxy server is "socks5://localhost:8080" (and NOT socks4://localhost:8080).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60734

[wtc, 2010-09-24 21:50:19]

LGTM.

Nit: add TEST= to the description of this CL.

[wtc, 2010-09-24 21:53:11]

http://codereview.chromium.org/3413037/diff/4001/5001
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/3413037/diff/4001/5001#newcode989
net/proxy/proxy_config_service_linux.cc:989: //
http://code.google.com/p/chromium/issues/detail?id=55912
Add #c2 to this URL?

[eroman, 2010-09-24 22:12:13]

Done. Here is the manual test comment I added (since we also have unit-tests):

TEST=Open Chrome in gnome. Go to options and change the network settings. This
will pop open the gnome network settings. In the dialog, enter the socks proxy
server as "localhost:8080". Now load chrome://net-internals/#proxy and verify
that it says the proxy server is "socks5://localhost:8080" (and NOT
socks4://localhost:8080).

http://codereview.chromium.org/3413037/diff/4001/5001
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/3413037/diff/4001/5001#newcode989
net/proxy/proxy_config_service_linux.cc:989: //
http://code.google.com/p/chromium/issues/detail?id=55912
On 2010/09/24 21:53:12, wtc wrote:
> Add #c2 to this URL?

Done.