Issue 3413011: modemmanager: Add a reason to ConnectionStateChanged events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3413011: modemmanager: Add a reason to ConnectionStateChanged events. (Closed)

Created:
10 years, 3 months ago by Elly Fong-Jones

Modified:
9 years, 3 months ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/modemmanager.git

Visibility:
Public.

Description

modemmanager: Add a reason to ConnectionStateChanged events. This can be used by a connection manager to decide to respond in a different way to certain kinds of disconnects (e.g. intentional versus unintentional versus suspension). TEST=None This change introduces no additional code, so testing it in isolation is not possible. BUG=chromium-os:6744 Change-Id: Ie371e20ec7a003333eba013af3ad61c0e494a4ad Signed-Off-By: Elly Jones <ellyjones@chromium.org>; Signed-Off-By: Jason Glasgow <jglasgow@chromium.org>;

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes per jglasgow. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	introspection/mm-modem.xml	View	1	2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

10 years, 3 months ago (2010-09-15 16:52:07 UTC) #2

I have a few minor comments/questions, but ether way LGTM.

http://codereview.chromium.org/3413011/diff/1/2
File introspection/mm-modem.xml (right):

http://codereview.chromium.org/3413011/diff/1/2#newcode95
introspection/mm-modem.xml:95: <tp:enum
name="MM_MODEM_CONNECTION_STATE_CHANGE_REASON" type="u">
It may mot matter, but should this be put at the bottom with the other
collection of tp:enums ?

http://codereview.chromium.org/3413011/diff/1/2#newcode122
introspection/mm-modem.xml:122: <arg name="reason" type="u">
should this also have  tp:type="MM_MODEM_CONNECTION_STATE_CHANGE_REASON" 
?

Expand Messages | Collapse Messages