Issue 3412033: Make feedback failure notification non sticky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3412033: Make feedback failure notification non sticky (Closed)

Created:
10 years, 3 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
rkc

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Make feedback failure notification non sticky BUG=chromium-os:6368 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60696

Patch Set 2 : " #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
M	chrome/browser/bug_report_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/low_battery_observer.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/network_message_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/notifications/system_notification.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/system_notification.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rkc

Other than the nit, LGTM http://codereview.chromium.org/3412033/diff/1/5 File chrome/browser/chromeos/notifications/system_notification.cc (right): http://codereview.chromium.org/3412033/diff/1/5#newcode56 chrome/browser/chromeos/notifications/system_notification.cc:56: sticky /* sticky */, ...

10 years, 3 months ago (2010-09-25 08:39:13 UTC) #2

oshima

10 years, 2 months ago (2010-09-27 20:02:29 UTC) #3

On 2010/09/25 08:39:13, rkc1 wrote:
> Other than the nit, LGTM
> 
> http://codereview.chromium.org/3412033/diff/1/5
> File chrome/browser/chromeos/notifications/system_notification.cc (right):
> 
> http://codereview.chromium.org/3412033/diff/1/5#newcode56
> chrome/browser/chromeos/notifications/system_notification.cc:56: sticky /*
> sticky */,
> Nit: The "/* sticky */" comment is no longer required.

done.

Expand Messages | Collapse Messages

Issue 3412033: Make feedback failure notification non sticky (Closed)

Description

Patch Set 1 #

Patch Set 2 : " #

Messages