Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: net/base/ssl_config_service.h

Issue 3412016: FBTF: Move a bunch of code to the headers and remove includes. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Rebase + fixed windows issues locally Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/sdch_manager.cc ('k') | net/base/ssl_config_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/ssl_config_service.h
diff --git a/net/base/ssl_config_service.h b/net/base/ssl_config_service.h
index f9d2245ae767246fc8e07bc5e69efff364ad68ad..f78e3dffbed6d9bf377ad8cbbf797fb088703d4f 100644
--- a/net/base/ssl_config_service.h
+++ b/net/base/ssl_config_service.h
@@ -18,12 +18,8 @@ namespace net {
struct SSLConfig {
// Default to revocation checking.
// Default to SSL 2.0 off, SSL 3.0 on, and TLS 1.0 on.
- SSLConfig()
- : rev_checking_enabled(true), ssl2_enabled(false), ssl3_enabled(true),
- tls1_enabled(true), dnssec_enabled(false), mitm_proxies_allowed(false),
- false_start_enabled(true), send_client_cert(false),
- verify_ev_cert(false), ssl3_fallback(false) {
- }
+ SSLConfig();
+ ~SSLConfig();
bool rev_checking_enabled; // True if server certificate revocation
// checking is enabled.
@@ -51,15 +47,7 @@ struct SSLConfig {
};
// Returns true if |cert| is one of the certs in |allowed_bad_certs|.
- // TODO(wtc): Move this to a .cc file. ssl_config_service.cc is Windows
- // only right now, so I can't move it there.
- bool IsAllowedBadCert(X509Certificate* cert) const {
- for (size_t i = 0; i < allowed_bad_certs.size(); ++i) {
- if (cert == allowed_bad_certs[i].cert)
- return true;
- }
- return false;
- }
+ bool IsAllowedBadCert(X509Certificate* cert) const;
// Add any known-bad SSL certificate (with its cert status) to
// |allowed_bad_certs| that should not trigger an ERR_CERT_* error when
@@ -108,8 +96,7 @@ class SSLConfigService : public base::RefCountedThreadSafe<SSLConfigService> {
virtual ~Observer() {}
};
- SSLConfigService()
- : observer_list_(ObserverList<Observer>::NOTIFY_EXISTING_ONLY) {}
+ SSLConfigService();
// Create an instance of SSLConfigService which retrieves the configuration
// from the system SSL configuration, or an instance of
@@ -157,7 +144,7 @@ class SSLConfigService : public base::RefCountedThreadSafe<SSLConfigService> {
protected:
friend class base::RefCountedThreadSafe<SSLConfigService>;
- virtual ~SSLConfigService() {}
+ virtual ~SSLConfigService();
// SetFlags sets the values of several flags based on global configuration.
static void SetSSLConfigFlags(SSLConfig*);
« no previous file with comments | « net/base/sdch_manager.cc ('k') | net/base/ssl_config_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698