Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 3411013: Make some runtime arguments checks be RUNTIME_ASSERT, not ASSERT. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein
Modified:
8 years, 1 month ago
Reviewers:
jokosuwito, Rico
CC:
v8-dev
Visibility:
Public.

Description

Make some runtime arguments checks be RUNTIME_ASSERT, not ASSERT.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. Remove fuzz-exception. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/runtime.cc View 1 3 chunks +10 lines, -9 lines 0 comments Download
M test/mjsunit/fuzz-natives.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein
10 years, 3 months ago (2010-09-17 08:11:04 UTC) #1
Rico
LGTM http://codereview.chromium.org/3411013/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/3411013/diff/1/2#newcode8955 src/runtime.cc:8955: CONVERT_BOOLEAN_CHECKED(enable, args[1]) and CONVERT_NUMBER_CHECKED for args[0]?
10 years, 3 months ago (2010-09-17 08:17:28 UTC) #2
Lasse Reichstein
http://codereview.chromium.org/3411013/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/3411013/diff/1/2#newcode8948 src/runtime.cc:8948: // args[0]: boolean indicating uncaught exceptions Comment is wrong ...
10 years, 3 months ago (2010-09-17 08:31:04 UTC) #3
Rico
LGTM
10 years, 3 months ago (2010-09-17 08:33:25 UTC) #4
jokosuwito
8 years, 1 month ago (2012-11-17 20:17:35 UTC) #5
re. Publish my gmail: <jokoswt@gmail.com>

Powered by Google App Engine
This is Rietveld 408576698