Implement window.alert() and its cousins for extensions....

Implement window.alert() and its cousins for extensions.

BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
  Make sure it gets the result back correctly.  Also make sure it still works when
  called from a web page.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31110

[Matt Perry, 2009-11-05 00:36:57]

Awesome! I like how clean this ended up being. LGTM with 1 style issue.

http://codereview.chromium.org/341089/diff/9009/10011
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/341089/diff/9009/10011#newcode428
Line 428: return active_tab->view()->GetTopLevelNativeWindow();
nit: I wonder if we should instead return the Browser's NativeWindow in this
case (and if we can access it from here).  Not a big deal, though.

http://codereview.chromium.org/341089/diff/9009/10018
File chrome/browser/jsmessage_box_client.h (right):

http://codereview.chromium.org/341089/diff/9009/10018#newcode44
Line 44: virtual TabContents* tab_contents() = 0;
AsTabContents (should use title case)

[Pam (message me for reviews), 2009-11-05 01:07:21]

http://codereview.chromium.org/341089/diff/9009/10011
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/341089/diff/9009/10011#newcode428
Line 428: return active_tab->view()->GetTopLevelNativeWindow();
On 2009/11/05 00:36:57, Matt Perry wrote:
> nit: I wonder if we should instead return the Browser's NativeWindow in this
> case (and if we can access it from here).  Not a big deal, though.

Neither Darin nor I could track down how to get a NativeWindow without going
through TabContents. If you know of one, I'd be happy  to use it.

[Matt Perry, 2009-11-05 01:11:15]

http://codereview.chromium.org/341089/diff/9009/10011
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/341089/diff/9009/10011#newcode428
Line 428: return active_tab->view()->GetTopLevelNativeWindow();
On 2009/11/05 01:07:21, Pam wrote:
> On 2009/11/05 00:36:57, Matt Perry wrote:
> > nit: I wonder if we should instead return the Browser's NativeWindow in this
> > case (and if we can access it from here).  Not a big deal, though.
> 
> Neither Darin nor I could track down how to get a NativeWindow without going
> through TabContents. If you know of one, I'd be happy  to use it.

I see. Carry on, then.

[Matt Perry, 2009-11-05 23:42:20]

http://codereview.chromium.org/341089/diff/5042/5044
File chrome/browser/app_modal_dialog.cc (right):

http://codereview.chromium.org/341089/diff/5042/5044#newcode68
Line 68: NotificationService::AllSources());
If you instead use Source<Tabcontents>(client_->AsTabContents()), you'll only
get notified when this tab is destroyed. That way you can avoid doing the
comparisons in Observe(). Ditto for Controller, assuming the TabContents
controller never changes.