Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: src/ia32/frames-ia32.cc

Issue 341082: Reverting 3174. Aka reapplying 3150, 3151 and 3159. Aka api accessor (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/frames-ia32.h ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 50
51 StackFrame::Type ExitFrame::GetStateForFramePointer(Address fp, State* state) { 51 StackFrame::Type ExitFrame::GetStateForFramePointer(Address fp, State* state) {
52 if (fp == 0) return NONE; 52 if (fp == 0) return NONE;
53 // Compute the stack pointer. 53 // Compute the stack pointer.
54 Address sp = Memory::Address_at(fp + ExitFrameConstants::kSPOffset); 54 Address sp = Memory::Address_at(fp + ExitFrameConstants::kSPOffset);
55 // Fill in the state. 55 // Fill in the state.
56 state->fp = fp; 56 state->fp = fp;
57 state->sp = sp; 57 state->sp = sp;
58 state->pc_address = reinterpret_cast<Address*>(sp - 1 * kPointerSize); 58 state->pc_address = reinterpret_cast<Address*>(sp - 1 * kPointerSize);
59 // Determine frame type. 59 return EXIT;
60 if (Memory::Address_at(fp + ExitFrameConstants::kDebugMarkOffset) != 0) {
61 return EXIT_DEBUG;
62 } else {
63 return EXIT;
64 }
65 } 60 }
66 61
67 62
68 void ExitFrame::Iterate(ObjectVisitor* v) const { 63 void ExitFrame::Iterate(ObjectVisitor* v) const {
69 // Exit frames on IA-32 do not contain any pointers. The arguments 64 v->VisitPointer(&code_slot());
70 // are traversed as part of the expression stack of the calling 65 // The arguments are traversed as part of the expression stack of
71 // frame. 66 // the calling frame.
72 } 67 }
73 68
74 69
75 int JavaScriptFrame::GetProvidedParametersCount() const { 70 int JavaScriptFrame::GetProvidedParametersCount() const {
76 return ComputeParametersCount(); 71 return ComputeParametersCount();
77 } 72 }
78 73
79 74
80 Address JavaScriptFrame::GetCallerStackPointer() const { 75 Address JavaScriptFrame::GetCallerStackPointer() const {
81 int arguments; 76 int arguments;
(...skipping 25 matching lines...) Expand all
107 102
108 103
109 Address InternalFrame::GetCallerStackPointer() const { 104 Address InternalFrame::GetCallerStackPointer() const {
110 // Internal frames have no arguments. The stack pointer of the 105 // Internal frames have no arguments. The stack pointer of the
111 // caller is at a fixed offset from the frame pointer. 106 // caller is at a fixed offset from the frame pointer.
112 return fp() + StandardFrameConstants::kCallerSPOffset; 107 return fp() + StandardFrameConstants::kCallerSPOffset;
113 } 108 }
114 109
115 110
116 } } // namespace v8::internal 111 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/frames-ia32.h ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698