Begin using the top-level code generator for code that is inside...

src/fast-codegen.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 57 matching lines @@
       break;
     default:
       UNREACHABLE();
   }
   return offset;
 }
 
 
 void FastCodeGenerator::VisitDeclarations(
     ZoneList<Declaration*>* declarations) {
+  Comment cmnt(masm_, "[ Declarations");
   int length = declarations->length();
   int globals = 0;
   for (int i = 0; i < length; i++) {
     Declaration* node = declarations->at(i);
     Variable* var = node->proxy()->var();
     Slot* slot = var->slot();
 
     // If it was not possible to allocate the variable at compile
     // time, we need to "declare" it at runtime to make sure it
     // actually exists in the local context.
@@ skipping 194 matching lines @@
 }
 
 
 void FastCodeGenerator::VisitEmptyStatement(EmptyStatement* stmt) {
   Comment cmnt(masm_, "[ EmptyStatement");
   SetStatementPosition(stmt);
 }
 
 
 void FastCodeGenerator::VisitIfStatement(IfStatement* stmt) {
+  Comment cmnt(masm_, "[ IfStatement");
   // Expressions cannot recursively enter statements, there are no labels in
   // the state.
   ASSERT_EQ(NULL, true_label_);
   ASSERT_EQ(NULL, false_label_);
   Label then_part, else_part, done;
 
   // Do not worry about optimizing for empty then or else bodies.
   true_label_ = &then_part;
   false_label_ = &else_part;
   ASSERT(stmt->condition()->context() == Expression::kTest);
@@ skipping 41 matching lines @@
   UNREACHABLE();
 }
 
 
 void FastCodeGenerator::VisitWhileStatement(WhileStatement* stmt) {
   UNREACHABLE();
 }
 
 
 void FastCodeGenerator::VisitForStatement(ForStatement* stmt) {
+  Comment cmnt(masm_, "[ ForStatement");
   Label test, body, exit;
   if (stmt->init() != NULL) Visit(stmt->init());
 
+  increment_loop_depth();

[Søren Thygesen Gjesse, 2009/11/03 13:57:47]

How placing the increment_loop_depth()/decrement_loop_depth() in a stack
allocated class to ensure they are paired. Maybe the other ASSERT in codegen
will catch this anyway.

[Kevin Millikin (Chromium), 2009/11/03 14:16:09]

I thought about that, but it seemed too complicated for this.  I'll leave it
like this for now and reconsider when I do the other loops.

   // Emit the test at the bottom of the loop (even if empty).
   __ jmp(&test);
   __ bind(&body);
   Visit(stmt->body());
   if (stmt->next() != NULL) Visit(stmt->next());
 
   __ bind(&test);
   if (stmt->cond() == NULL) {
     // For an empty test jump to the top of the loop.
     __ jmp(&body);
   } else {
     // We are not in an expression context because we have been compiling
     // statements.  Set up a test expression context for the condition.
     ASSERT_EQ(NULL, true_label_);
     ASSERT_EQ(NULL, false_label_);
     true_label_ = &body;
     false_label_ = &exit;
     ASSERT(stmt->cond()->context() == Expression::kTest);
     Visit(stmt->cond());
     true_label_ = NULL;
     false_label_ = NULL;
   }
 
   __ bind(&exit);
+  decrement_loop_depth();
 }
 
 
 void FastCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
   UNREACHABLE();
 }
 
 
 void FastCodeGenerator::VisitTryCatchStatement(TryCatchStatement* stmt) {
   UNREACHABLE();
@@ skipping 10 matching lines @@
 }
 
 
 void FastCodeGenerator::VisitFunctionBoilerplateLiteral(
     FunctionBoilerplateLiteral* expr) {
   UNREACHABLE();
 }
 
 
 void FastCodeGenerator::VisitConditional(Conditional* expr) {
+  Comment cmnt(masm_, "[ Conditional");
   ASSERT_EQ(Expression::kTest, expr->condition()->context());
   ASSERT_EQ(expr->context(), expr->then_expression()->context());
   ASSERT_EQ(expr->context(), expr->else_expression()->context());
 
 
   Label true_case, false_case, done;
   Label* saved_true = true_label_;
   Label* saved_false = false_label_;
 
   true_label_ = &true_case;
@@ skipping 20 matching lines @@
 }
 
 
 void FastCodeGenerator::VisitSlot(Slot* expr) {
   // Slots do not appear directly in the AST.
   UNREACHABLE();
 }
 
 
 void FastCodeGenerator::VisitLiteral(Literal* expr) {
+  Comment cmnt(masm_, "[ Literal");
   Move(expr->context(), expr);
 }
 
 
 void FastCodeGenerator::VisitAssignment(Assignment* expr) {
   Comment cmnt(masm_, "[ Assignment");
   ASSERT(expr->op() == Token::ASSIGN || expr->op() == Token::INIT_VAR);
 
   // Record source code position of the (possible) IC call.
   SetSourcePosition(expr->position());
@@ skipping 43 matching lines @@
 
 void FastCodeGenerator::VisitThisFunction(ThisFunction* expr) {
   UNREACHABLE();
 }
 
 
 #undef __
 
 
 } }  // namespace v8::internal