Issue 341074: Delete the temp dir created by CreateZip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341074: Delete the temp dir created by CreateZip. (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Delete the temp dir created by CreateZip. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30841

Patch Set 3 : fix header guard while I'm at it #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	chrome/browser/extensions/extension_creator.h	View	2	3 chunks	+5 lines, -4 lines	0 comments	Download
	M	chrome/browser/extensions/extension_creator.cc	View	1 2	3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/341074/diff/1/2 File chrome/browser/extensions/extension_creator.cc (right): http://codereview.chromium.org/341074/diff/1/2#newcode235 Line 235: file_util::Delete(zip_path.DirName(), false); // Delete temp dir. Nit: thanks ...

11 years, 1 month ago (2009-11-03 01:34:31 UTC) #2

lgtm, thanks

Expand Messages | Collapse Messages

Issue 341074: Delete the temp dir created by CreateZip. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix header guard while I'm at it #

Messages