Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 341067: libjingle: add missing include in asynctcpsocket.cc (Closed)

Created:
11 years, 1 month ago by Craig
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

libjingle: add missing include in asynctcpsocket.cc Error was: third_party/libjingle/files/talk/base/asynctcpsocket.cc:172: error: ‘strerror’ is not a member of ‘std’ Filed upstream: http://code.google.com/p/libjingle/issues/detail?id=54 TEST=builds with gcc 4.4 now Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/libjingle/files/talk/base/asynctcpsocket.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Craig
Any takers to review this please? It will only be needed once asynctcpsocket is part ...
11 years, 1 month ago (2009-11-02 17:42:27 UTC) #1
piman
lgtm. Just make sure it still builds on windows/mac, but I didn't have problems with ...
11 years, 1 month ago (2009-11-02 18:46:21 UTC) #2
Craig
11 years, 1 month ago (2009-11-02 19:07:36 UTC) #3
On 2009/11/02 18:46:21, piman wrote:
> lgtm.
> Just make sure it still builds on windows/mac, but I didn't have problems with
> the other files I fixed there.

Thank you. I will send it to try servers before I commit.

Powered by Google App Engine
This is Rietveld 408576698