Issue 341064: Don't use string slices when processing RexExp replace (re-apply r3153)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341064: Don't use string slices when processing RexExp replace (re-apply r3153)... (Closed)

Created:
11 years, 1 month ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Don't use string slices when processing RexExp replace (re-apply r3153) Re-apply r3153 with a fix for issue 490. Except for the change in line 1756 and the added test this change is identical to http://codereview.chromium.org/342015. BUG=490 TEST=test/mjsunit/regress/regress-490.js Committed: http://code.google.com/p/v8/source/detail?r=3197

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -14 lines)			Patch
M	src/runtime.cc	View	5 chunks	+45 lines, -11 lines	0 comments	Download
M	src/string.js	View	2 chunks	+6 lines, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-490.js	View	1 chunk	+48 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM