Issue 341060: [Mac] Prevent search engines from disappearing in the preferences list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341060: [Mac] Prevent search engines from disappearing in the preferences list (Closed)

Created:
11 years, 1 month ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Prevent search engines from disappearing in the preferences list * Fix the logic in -[SearchEngineListModel defaultIndex]. * Make the test data URLs in SearchEngineListModelTest replaceable, enabling more tests. * Add a test for this bug 21898. TEST=Preferences-->Manage. Add two new search engines. Make the second one default. The list in main Preferences should not have a blank entry. BUG=21898 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30700

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -9 lines)			Patch
	M	chrome/browser/cocoa/search_engine_list_model.mm	View		1 chunk	+9 lines, -4 lines	1 comment	Download
	M	chrome/browser/cocoa/search_engine_list_model_unittest.mm	View		3 chunks	+29 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

11 years, 1 month ago (2009-11-02 15:46:23 UTC) #2

LGTM, thanks for fixing the unit tests!

http://codereview.chromium.org/341060/diff/1/2
File chrome/browser/cocoa/search_engine_list_model.mm (right):

http://codereview.chromium.org/341060/diff/1/2#newcode97
Line 97: it != urls.end(); ++it) {
align with |std| above, not paren.

Expand Messages | Collapse Messages