Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 341044: Move chromeos code to namespace chromeos. (Closed)

Created:
11 years, 1 month ago by Charlie Lee (do not use)
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore, sky
CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Move chromeos code to namespace chromeos. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30541

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -1290 lines) Patch
M chrome/browser/browser_about_handler.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/browser_extenders.cc View 3 chunks +4 lines, -4 lines 1 comment Download
D chrome/browser/chromeos/chromeos_browser_extenders.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D chrome/browser/chromeos/chromeos_version_loader.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/chromeos/chromeos_version_loader.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/chromeos/chromeos_version_loader_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/clock_menu_button.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/clock_menu_button.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/compact_location_bar.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/compact_location_bar.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/compact_navigation_bar.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/compact_navigation_bar.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros_library.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros_library.cc View 3 chunks +5 lines, -1 line 0 comments Download
D chrome/browser/chromeos/cros_network_library.h View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/browser/chromeos/cros_network_library.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/chromeos/cros_power_library.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/chromeos/cros_power_library.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/browser/chromeos/external_cookie_handler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/external_cookie_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/external_cookie_handler_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/main_menu.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/main_menu.cc View 4 chunks +6 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/network_library.h View 7 chunks +18 lines, -14 lines 0 comments Download
chrome/browser/chromeos/network_library.cc View 11 chunks +38 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/network_menu_button.h View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/network_menu_button.cc View 10 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/panel_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/panel_controller.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/password_dialog_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/password_dialog_view.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/pipe_reader.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/pipe_reader.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/pipe_reader_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/power_library.h View 3 chunks +16 lines, -12 lines 0 comments Download
A + chrome/browser/chromeos/power_library.cc View 3 chunks +26 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/power_menu_button.h View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/power_menu_button.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings_contents_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings_contents_view.cc View 11 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/settings_page_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings_page_view.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status_area_button.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status_area_button.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status_area_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status_area_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/version_loader.h View 3 chunks +16 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/version_loader.cc View 5 chunks +12 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/version_loader_unittest.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/gtk/options/options_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_extender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Lee (do not use)
11 years, 1 month ago (2009-10-29 23:52:38 UTC) #1
sky
11 years, 1 month ago (2009-10-30 00:19:16 UTC) #2
LGTM with the following change.

http://codereview.chromium.org/341044/diff/1/26
File chrome/browser/chromeos/browser_extenders.cc (right):

http://codereview.chromium.org/341044/diff/1/26#newcode28
Line 28: namespace chromeos {
This should remain in an anonymous name space.

Powered by Google App Engine
This is Rietveld 408576698