Store the form name, source URL and target URL in FormFieldValues. These are...

Store the form name, source URL and target URL in FormFieldValues.  These are needed by AutoFill.

BUG=none
TEST=none

[darin (slow to review), 2009-10-29 21:32:27]

http://codereview.chromium.org/341042/diff/1/4
File chrome/common/render_messages.h (right):

http://codereview.chromium.org/341042/diff/1/4#newcode756
Line 756: && ReadParam(m, iter, &p->source_url)
nit: chrome style is to put the &&'s at the end of the line.

http://codereview.chromium.org/341042/diff/1/3
File webkit/glue/form_field_values.cc (right):

http://codereview.chromium.org/341042/diff/1/3#newcode43
Line 43: result->source_url = StringToString16(form->document()->documentURI());
documentURI is settable.  maybe you should use document()->url() instead?

http://codereview.chromium.org/341042/diff/1/2
File webkit/glue/form_field_values.h (right):

http://codereview.chromium.org/341042/diff/1/2#newcode28
Line 28: string16 source_url;
can you use GURL here?

[James Hawkins, 2009-10-29 21:42:50]

http://codereview.chromium.org/341042/diff/1/4
File chrome/common/render_messages.h (right):

http://codereview.chromium.org/341042/diff/1/4#newcode756
Line 756: && ReadParam(m, iter, &p->source_url)
On 2009/10/29 21:32:27, darin wrote:
> nit: chrome style is to put the &&'s at the end of the line.

Done.

http://codereview.chromium.org/341042/diff/1/3
File webkit/glue/form_field_values.cc (right):

http://codereview.chromium.org/341042/diff/1/3#newcode43
Line 43: result->source_url = StringToString16(form->document()->documentURI());
On 2009/10/29 21:32:27, darin wrote:
> documentURI is settable.  maybe you should use document()->url() instead?

Done.

http://codereview.chromium.org/341042/diff/1/2
File webkit/glue/form_field_values.h (right):

http://codereview.chromium.org/341042/diff/1/2#newcode28
Line 28: string16 source_url;
On 2009/10/29 21:32:27, darin wrote:
> can you use GURL here?

Done.

[darin (slow to review), 2009-10-29 22:14:46]

http://codereview.chromium.org/341042/diff/3002/3004
File webkit/glue/form_field_values.cc (right):

http://codereview.chromium.org/341042/diff/3002/3004#newcode43
Line 43: result->source_url = GURL(StringToString16(form->document()->url()));
nit: use KURLToGURL for this one

http://codereview.chromium.org/341042/diff/3002/3004#newcode44
Line 44: result->target_url = GURL(StringToString16(form->action()));
action may be a relative url, right?  maybe you want to return an absolute url? 
you could use Document::completeURL for that.  (sorry for not noticing this
before!)

[James Hawkins, 2009-10-29 22:28:57]

http://codereview.chromium.org/341042/diff/3002/3004
File webkit/glue/form_field_values.cc (right):

http://codereview.chromium.org/341042/diff/3002/3004#newcode43
Line 43: result->source_url = GURL(StringToString16(form->document()->url()));
On 2009/10/29 22:14:46, darin wrote:
> nit: use KURLToGURL for this one

Done.

http://codereview.chromium.org/341042/diff/3002/3004#newcode44
Line 44: result->target_url = GURL(StringToString16(form->action()));
On 2009/10/29 22:14:46, darin wrote:
> action may be a relative url, right?  maybe you want to return an absolute
url? 
> you could use Document::completeURL for that.  (sorry for not noticing this
> before!)

Done.

[darin (slow to review), 2009-10-30 04:22:23]

LGTM