Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: webkit/tools/layout_tests/run_webkit_tests.py

Issue 341040: Rename a variable to avoid shadowing.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/layout_tests/run_webkit_tests.py
===================================================================
--- webkit/tools/layout_tests/run_webkit_tests.py (revision 30382)
+++ webkit/tools/layout_tests/run_webkit_tests.py (working copy)
@@ -790,8 +790,8 @@
else:
dictionary[key] = 1
- for test, failures in failures.iteritems():
- for failure in failures:
+ for test, failure_types in failures.iteritems():
+ for failure_type in failure_types:
# TODO(ojan): Now that we have IMAGE+TEXT, IMAGE and TEXT,
# we can avoid adding multiple failures per test since there should
# be a unique type of failure for each test. This would make the
@@ -806,7 +806,7 @@
count_group = fixable_counts
failure_group = fixable_failures
- AddFailure(count_group, failure.__class__)
+ AddFailure(count_group, failure_type.__class__)
failure_group.add(test)
# Here and below, use the prechuncked expectations object for numbers of
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698