Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/common/sandbox_init_wrapper.h

Issue 341033: Sandbox Worker process on the Mac. (Closed)
Patch Set: Fix latest round of comments Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/common/sandbox_init_wrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/sandbox_init_wrapper.h
diff --git a/chrome/common/sandbox_init_wrapper.h b/chrome/common/sandbox_init_wrapper.h
index a1c2de9b17780cd4512e757fac635f9676f3de60..d1652d2172f31cc385442df41bc6f5e77258704f 100644
--- a/chrome/common/sandbox_init_wrapper.h
+++ b/chrome/common/sandbox_init_wrapper.h
@@ -33,7 +33,10 @@ class SandboxInitWrapper {
// Initialize the sandbox for renderer and plug-in processes, depending on
// the command line flags. The browser process is not sandboxed.
- void InitializeSandbox(const CommandLine& parsed_command_line,
+ // Returns true if the sandbox was initialized succesfully, false if an error
+ // occurred. If process_type isn't one that needs sandboxing true is always
+ // returned.
+ bool InitializeSandbox(const CommandLine& parsed_command_line,
const std::string& process_type);
private:
sandbox::BrokerServices* broker_services_;
@@ -50,17 +53,12 @@ class SandboxInitWrapper {
// Initialize the sandbox for renderer and plug-in processes, depending on
// the command line flags. The browser process is not sandboxed.
- void InitializeSandbox(const CommandLine& parsed_command_line,
+ // Returns true if the sandbox was initialized succesfully, false if an error
+ // occurred. If process_type isn't one that needs sandboxing true is always
+ // returned.
+ bool InitializeSandbox(const CommandLine& parsed_command_line,
const std::string& process_type);
-#if defined(OS_MACOSX)
- // We keep the process type so we can configure the sandbox as needed.
- public:
- std::string ProcessType() const { return process_type_; }
- private:
- std::string process_type_;
-#endif
-
private:
DISALLOW_COPY_AND_ASSIGN(SandboxInitWrapper);
};
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/common/sandbox_init_wrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698