Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 341030: Moves webview_impl.cc, webframe_impl.cc and webframeloaderclient_impl.cc into... (Closed)

Created:
11 years, 1 month ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
yaar
CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, darin (slow to review), jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Moves webview_impl.cc, webframe_impl.cc and webframeloaderclient_impl.cc into webkit/api/src. R=yaar BUG=25896, 25897, 25902 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30558

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 4

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4831 lines, -10905 lines) Patch
A webkit/api/src/AutocompletePopupMenuClient.h View 1 chunk +96 lines, -0 lines 0 comments Download
A webkit/api/src/AutocompletePopupMenuClient.cpp View 1 2 3 4 5 6 7 8 1 chunk +178 lines, -0 lines 0 comments Download
M webkit/api/src/BackForwardListClientImpl.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/api/src/BackForwardListClientImpl.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -6 lines 0 comments Download
M webkit/api/src/ChromeClientImpl.h View 1 2 3 4 5 6 7 8 9 2 chunks +1 line, -2 lines 0 comments Download
M webkit/api/src/ChromeClientImpl.cpp View 1 2 3 4 5 6 7 8 9 15 chunks +20 lines, -23 lines 0 comments Download
M webkit/api/src/ContextMenuClientImpl.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M webkit/api/src/ContextMenuClientImpl.cpp View 1 2 3 4 5 6 7 8 9 5 chunks +14 lines, -17 lines 0 comments Download
M webkit/api/src/DragClientImpl.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M webkit/api/src/DragClientImpl.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/api/src/EditorClientImpl.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M webkit/api/src/EditorClientImpl.cpp View 1 2 3 4 5 6 7 8 9 7 chunks +14 lines, -13 lines 0 comments Download
A + webkit/api/src/FrameLoaderClientImpl.h View 1 chunk +200 lines, -214 lines 0 comments Download
A + webkit/api/src/FrameLoaderClientImpl.cpp View 1 2 3 4 5 6 4 chunks +947 lines, -878 lines 0 comments Download
M webkit/api/src/InspectorClientImpl.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M webkit/api/src/InspectorClientImpl.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -3 lines 0 comments Download
A + webkit/api/src/WebFrameImpl.h View 2 chunks +292 lines, -313 lines 0 comments Download
A + webkit/api/src/WebFrameImpl.cpp View 1 2 3 4 5 4 chunks +1339 lines, -1370 lines 0 comments Download
M webkit/api/src/WebStorageEventDispatcherImpl.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/api/src/WebViewImpl.h View 2 chunks +327 lines, -309 lines 0 comments Download
A + webkit/api/src/WebViewImpl.cpp View 1 2 3 4 5 6 7 8 5 chunks +1276 lines, -1434 lines 0 comments Download
M webkit/api/src/WebWorkerClientImpl.cpp View 7 8 9 2 chunks +4 lines, -6 lines 0 comments Download
M webkit/api/src/WebWorkerImpl.cpp View 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/devtools/debugger_agent_impl.h View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -4 lines 0 comments Download
M webkit/glue/devtools/debugger_agent_impl.cc View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/devtools/debugger_agent_manager.h View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -5 lines 0 comments Download
M webkit/glue/devtools/debugger_agent_manager.cc View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -3 lines 0 comments Download
M webkit/glue/dom_operations.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/dom_operations.cc View 1 2 3 4 5 6 7 8 9 3 chunks +10 lines, -8 lines 0 comments Download
M webkit/glue/dom_operations_private.h View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/glue/dom_serializer.h View 1 2 3 4 5 6 7 8 9 4 chunks +3 lines, -4 lines 0 comments Download
M webkit/glue/dom_serializer.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/dom_serializer_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/image_resource_fetcher.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/password_autocomplete_listener_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +7 lines, -4 lines 0 comments Download
M webkit/glue/webaccessibilitymanager_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.h View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -6 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -1 line 0 comments Download
M webkit/glue/webdevtoolsfrontend_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -3 lines 0 comments Download
M webkit/glue/webdevtoolsfrontend_impl.cc View 1 2 3 4 5 6 7 8 9 4 chunks +7 lines, -4 lines 0 comments Download
D webkit/glue/webframe_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -397 lines 0 comments Download
D webkit/glue/webframe_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1921 lines 0 comments Download
D webkit/glue/webframeloaderclient_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -244 lines 0 comments Download
D webkit/glue/webframeloaderclient_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1339 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 2 3 4 5 6 7 8 9 5 chunks +8 lines, -6 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 3 4 5 6 7 8 9 6 chunks +6 lines, -3 lines 0 comments Download
D webkit/glue/webview_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -401 lines 0 comments Download
D webkit/glue/webview_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1925 lines 0 comments Download
M webkit/webkit.gyp View 2 3 4 5 6 7 8 9 6 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 1 month ago (2009-10-29 18:18:31 UTC) #1
yaar
11 years, 1 month ago (2009-10-29 20:53:54 UTC) #2
LGTM except nits.

p.s. you owe me an Advil

http://codereview.chromium.org/341030/diff/72/1093
File webkit/api/src/FrameLoaderClientImpl.cpp (right):

http://codereview.chromium.org/341030/diff/72/1093#newcode893
Line 893: WebURLError url_error = error;
nit: urlError

http://codereview.chromium.org/341030/diff/72/1093#newcode1210
Line 1210: // WebHistoryItemImpl* item_impl =
static_cast<WebHistoryItemImpl*>(item);
nit: item_impl -> itemImpl (even though its in a comment)

http://codereview.chromium.org/341030/diff/72/1093#newcode1250
Line 1250: const ResourceRequest& request,
nit: indent off by 1 space

http://codereview.chromium.org/341030/diff/72/1093#newcode1303
Line 1303: WebPlugin* webplugin = m_webFrame->client()->createPlugin(m_webFrame,
params);
nit: webPlugin

Powered by Google App Engine
This is Rietveld 408576698