Issue 341029: Only dispatch tab events when there is someone listening

Issue 341029: Only dispatch tab events when there is someone listening (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin, rafaelw

CC:
chromium-reviews_googlegroups.com, tony

Visibility:
Public.

Description

Only dispatch tab events when there is someone listening. This should cut down on the number of occurrences of a crash that happens in JSON serialization. BUG=25558, 26169 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30444

Patch Set 1 #

Patch Set 2 : pre-review #

Total comments: 3

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
M	chrome/browser/extensions/extensions_service.cc	View	1	2 chunks	+6 lines, -3 lines	3 comments	Download
M	chrome/common/extensions/extension.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM, though I don't know this code too well http://codereview.chromium.org/341029/diff/1001/2001 File chrome/browser/extensions/extensions_service.cc (right): http://codereview.chromium.org/341029/diff/1001/2001#newcode511 Line ...

11 years, 1 month ago (2009-10-29 01:56:29 UTC) #2

Aaron Boodman

http://codereview.chromium.org/341029/diff/1001/2001 File chrome/browser/extensions/extensions_service.cc (right): http://codereview.chromium.org/341029/diff/1001/2001#newcode511 Line 511: ExtensionBrowserEventRouter::GetInstance()->Init(); On 2009/10/29 01:56:29, Evan Martin wrote: > ...

11 years, 1 month ago (2009-10-29 04:03:25 UTC) #3

rafaelw

11 years, 1 month ago (2009-10-29 04:08:46 UTC) #4

lgtm. it'd be nice to unify how the tabs module and bookmarks module do
initialization at some point.

http://codereview.chromium.org/341029/diff/1001/2001
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/341029/diff/1001/2001#newcode511
Line 511: ExtensionBrowserEventRouter::GetInstance()->Init();
Don't need braces

On 2009/10/29 01:56:29, Evan Martin wrote:
> Are you certain there's no other way for this to be created such that Init
isn't
> called?

Expand Messages | Collapse Messages