Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 341024: Report function source position via JSON protocol (Closed)

Created:
11 years, 1 month ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Report function source position via JSON protocol Committed: http://code.google.com/p/v8/source/detail?r=3189

Patch Set 1 #

Patch Set 2 : clean-up #

Total comments: 2

Patch Set 3 : merge #

Patch Set 4 : bring back missing method #

Patch Set 5 : rename field #

Patch Set 6 : follow codereview #

Patch Set 7 : clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -9 lines) Patch
M src/mirror-delay.js View 1 2 3 4 5 6 4 chunks +56 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Rybin
Hi Sorren Could you please take a look at this change? Thanks, Peter
11 years, 1 month ago (2009-10-28 21:17:13 UTC) #1
Søren Thygesen Gjesse
LGTM Please update http://code.google.com/p/v8/wiki/DebuggerProtocol as well. http://codereview.chromium.org/341024/diff/1001/2001 File src/mirror-delay.js (right): http://codereview.chromium.org/341024/diff/1001/2001#newcode2261 Line 2261: content.locals = ...
11 years, 1 month ago (2009-10-28 22:16:37 UTC) #2
Peter Rybin
Hi Soren I brought back lost method and re-used new function as you asked. Peter ...
11 years, 1 month ago (2009-10-30 16:33:26 UTC) #3
Peter Rybin
11 years, 1 month ago (2009-10-30 20:50:34 UTC) #4
On 2009/10/28 22:16:37, Søren Gjesse wrote:
> Please update http://code.google.com/p/v8/wiki/DebuggerProtocol as well.

Done,
r3190, r3191

Powered by Google App Engine
This is Rietveld 408576698