Issue 341015: Fix paint glitch on load/unload browser action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341015: Fix paint glitch on load/unload browser action (Closed)

Created:
11 years, 1 month ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix paint glitch on load/unload browser action. This asks the toolbar (BrowserActionContainer.GetParent()) to paint when a browser action view has been added & removed. TEST=Load browser action. Go to chrome://extensions, click "reload". The omnibar should visibly flash large & small as the browser action is loaded and unload, but it should not leave behind any visible "cruft" around the browser action. BUG=24642 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30310

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/views/browser_actions_container.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages