Issue 341006: Don't hang during DiskCacheEntryTest.CancelSparseIO on infinitely fast disks....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341006: Don't hang during DiskCacheEntryTest.CancelSparseIO on infinitely fast disks.... (Closed)

Created:
11 years, 1 month ago by dank

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't hang during DiskCacheEntryTest.CancelSparseIO on infinitely fast disks.

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	net/disk_cache/entry_unittest.cc	View		1 chunk	+9 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dank

This shouldn't affect the test normally; only very strange environments (like mine) run into this ...

11 years, 1 month ago (2009-10-27 21:53:28 UTC) #1

rvargas (doing something else)

LGTM http://codereview.chromium.org/341006/diff/1/2 File net/disk_cache/entry_unittest.cc (right): http://codereview.chromium.org/341006/diff/1/2#newcode1360 Line 1360: const int maxtries = 1000; // Avoid ...

11 years, 1 month ago (2009-10-27 23:04:58 UTC) #2

dank

11 years, 1 month ago (2009-10-28 00:27:07 UTC) #3

OK, lowered limit to 100 and committed, thanks.
(That is 50x normal margin, 10x the worst I've seen, 
and the failure mode is rather benign.)

Expand Messages | Collapse Messages