Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 3410019: monitor_reconfig: Disable external output to avoid error. (Closed)

Created:
10 years, 3 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, sosa
Visibility:
Public.

Description

monitor_reconfig: Disable external output to avoid error. If we're using 1920x1200 on an external output and then unplug it and try to switch back to 1366x768, xrandr gives us an error like: xrandr: specified screen 1366x768 not large enough for output VGA1 (1920x1200+0+0) when trying to set the screen size. I think that this is harmless, but it's easy enough to disable the external output first in this case before adjusting the screen size. Change-Id: I344f5af66657cb935b33d4398ec8a94befcf2ead BUG=none TEST=plugged and unplugged VGA and ran monitor_reconfigure a bunch Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a233cdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M monitor_reconfigure_main.h View 1 chunk +4 lines, -1 line 0 comments Download
M monitor_reconfigure_main.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
10 years, 3 months ago (2010-09-17 16:11:19 UTC) #1
sosa
10 years, 3 months ago (2010-09-17 17:41:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698