Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 3410014: Fix direct loading of global function prototypes: (Closed)

Created:
10 years, 3 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund, fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix direct loading of global function prototypes: We must also check the current context has not changed. The bug reported by Florian. Committed: http://code.google.com/p/v8/source/detail?r=5483

Patch Set 1 #

Patch Set 2 : Added a test for Boolean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -23 lines) Patch
M src/arm/stub-cache-arm.cc View 6 chunks +13 lines, -6 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M src/stub-cache.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 6 chunks +13 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
10 years, 3 months ago (2010-09-16 16:32:50 UTC) #1
Kasper Lund
10 years, 3 months ago (2010-09-17 05:05:47 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698