Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 3410011: Fix a regression in character-at stub when doing a keyed load on a string. ... (Closed)

Created:
10 years, 3 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix a regression in character-at stub when doing a keyed load on a string. Loading from out-of-range has to go to the runtime system to check if there exists a property with that index in the prototype. Committed: http://code.google.com/p/v8/source/detail?r=5471

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M src/arm/ic-arm.cc View 3 chunks +1 line, -6 lines 0 comments Download
M src/ia32/ic-ia32.cc View 3 chunks +1 line, -6 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +1 line, -6 lines 0 comments Download
M test/mjsunit/regress/regress-900966.js View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
fschneider
10 years, 3 months ago (2010-09-16 09:10:55 UTC) #1
Kasper Lund
10 years, 3 months ago (2010-09-16 09:17:05 UTC) #2
LGTM.

http://codereview.chromium.org/3410011/diff/1/5
File test/mjsunit/regress/regress-900966.js (right):

http://codereview.chromium.org/3410011/diff/1/5#newcode38
test/mjsunit/regress/regress-900966.js:38: f();
Add a comment about why you need two calls here.

Powered by Google App Engine
This is Rietveld 408576698