Issue 3405037: Fixed user feedback crash on parameter check (std exception was thrown)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3405037: Fixed user feedback crash on parameter check (std exception was thrown).... (Closed)

Created:
10 years, 2 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
dhg

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed user feedback crash on parameter check (std exception was thrown). BUG=chromium-os:6543 TEST=make sure chrome:bugreport does not throw exception Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60732

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/dom_ui/bug_report_ui.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dhg

10 years, 2 months ago (2010-09-27 21:40:28 UTC) #2

LGTM

On Mon, Sep 27, 2010 at 2:38 PM,  <zelidrag@chromium.org> wrote:
> Reviewers: dhg,
>
> Description:
> Fixed user feedback crash on parameter check (std exception was thrown).
>
>
> BUG=chromium-os:6543
> TEST=make sure chrome:bugreport does not throw exception
>
>
> Please review this at http://codereview.chromium.org/3405037/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/dom_ui/bug_report_ui.cc
>
>
> Index: chrome/browser/dom_ui/bug_report_ui.cc
> ===================================================================
> --- chrome/browser/dom_ui/bug_report_ui.cc      (revision 60692)
> +++ chrome/browser/dom_ui/bug_report_ui.cc      (working copy)
> @@ -454,7 +454,8 @@
>
>   std::string params =
> page_url.substr(strlen(chrome::kChromeUIBugReportURL));
>   // Erase the # - the first character.
> -  params.erase(params.begin(),params.begin() + 1);
> +  if (params.length())
> +    params.erase(params.begin(),params.begin() + 1);
>
>   int index = 0;
>   if (!base::StringToInt(params, &index)) {
>
>
>

Expand Messages | Collapse Messages