Issue 3405022: Unuse labels when bailing out of StubCompiler methods....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3405022: Unuse labels when bailing out of StubCompiler methods.... (Closed)

Created:
10 years, 3 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
antonm, Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Unuse labels when bailing out of StubCompiler methods. There are 3 methods where early return happen before the miss label is bound. This is harmless in Release mode, in Debug an assertion fails. Committed: http://code.google.com/p/v8/source/detail?r=5508

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -9 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	3 chunks	+12 lines, -3 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	3 chunks	+13 lines, -3 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	3 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Good catch! LGTM

Expand Messages | Collapse Messages