Issue 3405016: add per-step failure support for WiFi tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3405016: add per-step failure support for WiFi tests (Closed)

Created:
10 years, 3 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
Paul Stewart

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@chromiumos-git//autotest.git

Visibility:
Public.

Description

add per-step failure support for WiFi tests Each step in a test can now be prefixed by "!" to indicate the step will fail. This is a convenient mechanism for testing connection requests that should fail (e.g. due to invalid parameters). We should check the error thrown is what we expect but right now that's painful. BUG=none TEST=035CheckWEPKeySyntax (coming in another CL) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5c58273

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	server/site_wifitest.py	View	1	3 chunks	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Stewart

LGTM -- it has a minor issue with the iterator. BTW, how about a "expect_nothing_but_failure" ...

10 years, 3 months ago (2010-09-18 01:22:28 UTC) #2

Sam Leffler

Not sure what this "minor issue with the iterator" is, can you be more specific? ...

10 years, 3 months ago (2010-09-18 19:36:48 UTC) #3

Sam Leffler

PTAL, fixed success case. Re-tested against MatFunc+SecMat+new key syntax checks

10 years, 2 months ago (2010-09-27 18:25:35 UTC) #4

LGTM

Expand Messages | Collapse Messages

Issue 3405016: add per-step failure support for WiFi tests (Closed)

Description

Patch Set 1 #

Patch Set 2 : fail if step succeeds but expect_failure is True; also remove dead break #

Patch Set 3 : handle success case #

Messages