Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: webkit/tools/test_shell/test_webview_delegate.cc

Issue 3404027: webkit: Append base:: in the StringPrintf calls. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_webview_delegate.cc
diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc
index c3dfeaecf068d46200a1b5672d659350011e4d1d..44e60f08fcde516fab27a9fbbfa2dc7e02c8d8e2 100644
--- a/webkit/tools/test_shell/test_webview_delegate.cc
+++ b/webkit/tools/test_shell/test_webview_delegate.cc
@@ -12,6 +12,7 @@
#include "base/message_loop.h"
#include "base/process_util.h"
#include "base/string_util.h"
+#include "base/stringprintf.h"
#include "base/trace_event.h"
#include "base/string_number_conversions.h"
#include "base/utf_string_conversions.h"
@@ -207,9 +208,9 @@ std::string GetResponseDescription(const WebURLResponse& response) {
return "(null)";
const std::string url = GURL(response.url()).possibly_invalid_spec();
- return StringPrintf("<NSURLResponse %s, http status code %d>",
- DescriptionSuitableForTestResult(url).c_str(),
- response.httpStatusCode());
+ return base::StringPrintf("<NSURLResponse %s, http status code %d>",
+ DescriptionSuitableForTestResult(url).c_str(),
+ response.httpStatusCode());
}
std::string GetErrorDescription(const WebURLError& error) {
@@ -237,7 +238,7 @@ std::string GetErrorDescription(const WebURLError& error) {
DLOG(WARNING) << "Unknown error domain";
}
- return StringPrintf("<NSError domain %s, code %d, failing URL \"%s\">",
+ return base::StringPrintf("<NSError domain %s, code %d, failing URL \"%s\">",
domain.c_str(), code, error.unreachableURL.spec().data());
}
@@ -899,7 +900,7 @@ void TestWebViewDelegate::didFailProvisionalLoad(
bool replace = extra_data && extra_data->pending_page_id != -1;
const std::string& error_text =
- StringPrintf("Error %d when loading url %s", error.reason,
+ base::StringPrintf("Error %d when loading url %s", error.reason,
failed_ds->request().url().spec().data());
// Make sure we never show errors in view source mode.
« no previous file with comments | « webkit/tools/test_shell/mock_spellcheck_unittest.cc ('k') | webkit/tools/test_shell/text_input_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698