Issue 3404027: webkit: Append base:: in the StringPrintf calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3404027: webkit: Append base:: in the StringPrintf calls. (Closed)

Created:
10 years, 2 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, michaeln, fbarchard, Alpha Left Google, pam+watch_chromium.org, jam, dpranke+watch_chromium.org, darin-cc_chromium.org, awong, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org, scherkus (not reviewing)

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

webkit: Append base:: in the StringPrintf calls. (Note: This is a TODO in string_util.h) BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60885

Patch Set 1 : #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -57 lines)			Patch
M	webkit/appcache/appcache_host.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/appcache/appcache_update_job.cc	View	5 chunks	+11 lines, -10 lines	0 comments	Download
M	webkit/appcache/appcache_url_request_job.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	webkit/appcache/web_application_cache_host_impl.cc	View	4 chunks	+7 lines, -4 lines	0 comments	Download
M	webkit/glue/cpp_variant.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/glue/media/buffered_data_source_unittest.cc	View	4 chunks	+13 lines, -12 lines	0 comments	Download
M	webkit/glue/media/media_resource_loader_bridge_factory.cc	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	webkit/glue/plugins/test/plugin_arguments_test.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_win.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/webplugin_impl.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/glue/user_agent.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/support/webkit_support.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/mock_spellcheck_unittest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/text_input_controller.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages