AU: move AU completed marker from /tmp to /var/run since /var/run is root-only.

AU: move AU completed marker from /tmp to /var/run since /var/run is root-only.

BUG=6578
TEST=unit tests, gmerged on device, updated, restarted update engine and
checked status

Change-Id: If703b66f1bf6efa13f25225d3c5868bc3dd190b7

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cd1666f

[adlr, 2010-09-22 16:48:30]

LGTM if chris is happy

On Wed, Sep 22, 2010 at 9:45 AM, <petkov@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> AU: move AU completed marker from /tmp to /var/run since /var/run is
> root-only.
>
> BUG=6578
> TEST=unit tests, gmerged on device, updated, restarted update engine and
> checked status
>
> Change-Id: If703b66f1bf6efa13f25225d3c5868bc3dd190b7
>
> Please review this at http://codereview.chromium.org/3404015/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M update_attempter.cc
>  M update_attempter_unittest.cc
>
>
> Index: update_attempter.cc
> diff --git a/update_attempter.cc b/update_attempter.cc
> index
>
a1568a923d266cd64bae69e890351eec93616568..73b93b8b7829b2dc400fe049bd73235c5c2e0f99
> 100644
> --- a/update_attempter.cc
> +++ b/update_attempter.cc
> @@ -36,7 +36,8 @@ using std::vector;
>
>  namespace chromeos_update_engine {
>
> -const char* kUpdateCompletedMarker =
> "/tmp/update_engine_autoupdate_completed";
> +const char* kUpdateCompletedMarker =
> +    "/var/run/update_engine_autoupdate_completed";
>
>  const char* UpdateStatusToString(UpdateStatus status) {
>   switch (status) {
> Index: update_attempter_unittest.cc
> diff --git a/update_attempter_unittest.cc b/update_attempter_unittest.cc
> index
>
0a02d1cc9e68c7334e36e58c77623defaa77f593..ed585729920f0b5c10db102e6e588cfe69e9eae5
> 100644
> --- a/update_attempter_unittest.cc
> +++ b/update_attempter_unittest.cc
> @@ -20,7 +20,7 @@ using testing::Return;
>  namespace chromeos_update_engine {
>
>  // Test a subclass rather than the main class directly so that we can mock
> out
> -// methods within the class. There're explicit unit test for the mocked
> out
> +// methods within the class. There're explicit unit tests for the mocked
> out
>  // methods.
>  class UpdateAttempterUnderTest : public UpdateAttempter {
>  public:
> @@ -52,7 +52,7 @@ class UpdateAttempterTest : public ::testing::Test {
>   ActionProcessorMock* processor_;
>  };
>
> -TEST_F(UpdateAttempterTest, ConstructWithUpdatedMarkerTest) {
> +TEST_F(UpdateAttempterTest, RunAsRootConstructWithUpdatedMarkerTest) {
>   extern const char* kUpdateCompletedMarker;
>   const FilePath kMarker(kUpdateCompletedMarker);
>   EXPECT_EQ(0, file_util::WriteFile(kMarker, "", 0));
>
>
>

[Chris Masone, 2010-09-22 16:58:46]

LGTM