autotest: Make WM tests wait for initial browser window.

autotest: Make WM tests wait for initial browser window.

I suspect that at least some of the failures that have been
seen from the desktopui_WindowManager* tests may be caused
by the tests starting to do things before the initial
browser window has been mapped, and then the focus ending up
on the browser window when it finally shows up.

I'm also removing some Alt-Tab/Alt-Shift-Tab hotkey-sending
from desktopui_WindowManagerFocusNewWindows that seems to be
flaky.  I haven't been able to figure out what's going on
here, but we already have a separate test that tests other
hotkeys, so this doesn't seem particularly useful to test.

Change-Id: I1b466adadb15d1964e8dda098fd353cd648255cc

BUG=chromium-os:3095
TEST=ran the tests a few times and only saw "waiting for logout" failures that are presumably caused by the slow USB stick that I booted from

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=384b2ec

[Daniel Erat, 2010-09-17 17:31:56]

http://codereview.chromium.org/3404010/diff/1/2
File
client/site_tests/desktopui_WindowManagerFocusNewWindows/desktopui_WindowManagerFocusNewWindows.py
(right):

http://codereview.chromium.org/3404010/diff/1/2#newcode25
client/site_tests/desktopui_WindowManagerFocusNewWindows/desktopui_WindowManagerFocusNewWindows.py:25:
desc='Waiting for _NET_ACTIVE_WINDOW to contain 0x%x' % id)
The window manager sets the property before it assigns the focus, so it makes
sense to check them in the same order in the test.

[kmixter1, 2010-09-17 20:32:37]

LGTM

http://codereview.chromium.org/3404010/diff/1/2
File
client/site_tests/desktopui_WindowManagerFocusNewWindows/desktopui_WindowManagerFocusNewWindows.py
(right):

http://codereview.chromium.org/3404010/diff/1/2#newcode25
client/site_tests/desktopui_WindowManagerFocusNewWindows/desktopui_WindowManagerFocusNewWindows.py:25:
desc='Waiting for _NET_ACTIVE_WINDOW to contain 0x%x' % id)
On 2010/09/17 17:31:57, Daniel Erat wrote:
> The window manager sets the property before it assigns the focus, so it makes
> sense to check them in the same order in the test.

Not sure if this reordering is being done to be more consistent with the
underlying code (which makes sense) or is being done to try to avoid some kind
of race condition - if the latter, it doesn't seem like it would be improved
much.

[Daniel Erat, 2010-09-17 20:39:13]

Thanks!

http://codereview.chromium.org/3404010/diff/1/2
File
client/site_tests/desktopui_WindowManagerFocusNewWindows/desktopui_WindowManagerFocusNewWindows.py
(right):

http://codereview.chromium.org/3404010/diff/1/2#newcode25
client/site_tests/desktopui_WindowManagerFocusNewWindows/desktopui_WindowManagerFocusNewWindows.py:25:
desc='Waiting for _NET_ACTIVE_WINDOW to contain 0x%x' % id)
On 2010/09/17 20:32:37, kmixter1 wrote:
> On 2010/09/17 17:31:57, Daniel Erat wrote:
> > The window manager sets the property before it assigns the focus, so it
makes
> > sense to check them in the same order in the test.
> 
> Not sure if this reordering is being done to be more consistent with the
> underlying code (which makes sense) or is being done to try to avoid some kind
> of race condition - if the latter, it doesn't seem like it would be improved
> much.

It's the former. :-)