Issue 340079: Use public SVN URL for drover....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340079: Use public SVN URL for drover.... (Closed)

Created:
11 years, 1 month ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, laforge

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Use public SVN URL for drover. BUG=none TEST=drover can access SVN server from outside Google Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30888

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	drover.py	View		4 chunks	+4 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chase

At some point we should clean up the settings in drover so the SVN URL ...

11 years, 1 month ago (2009-11-03 22:16:15 UTC) #1

Nicolas Sylvain

LGTM Anthony: This means next time you use the tool it might ask for password. ...

11 years, 1 month ago (2009-11-03 23:01:05 UTC) #2

laforge

11 years, 1 month ago (2009-11-03 23:13:04 UTC) #3

LGTM
On 2009/11/03 23:01:05, Nicolas Sylvain wrote:
> LGTM
> 
> Anthony: This means next time you use the tool it might ask for password.
> 
> http://codereview.chromium.org/340079/diff/1/2
> File drover.py (right):
> 
> http://codereview.chromium.org/340079/diff/1/2#newcode276
> Line 276: if(isSVNDirectory("svn://svn.chromium.org/chrome/" + file_info[1],
> revision)):
> 80 char,
> eventually we should make it a global variable.
> 
> http://codereview.chromium.org/340079/diff/1/2#newcode295
> Line 295: if(isSVNDirectory("svn://svn.chromium.org/chrome/" + file_info[1],
> revision)):
> 80 char

Expand Messages | Collapse Messages