Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 340070: Allow trailing dots on hostnames.... (Closed)

Created:
11 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.
Visibility:
Public.

Description

Allow trailing dots on hostnames. BUG=25962 TEST=Type in "google.com." and verify you can navigate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M net/base/net_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M net/base/net_util_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 1 month ago (2009-11-02 23:52:33 UTC) #1
brettw
11 years, 1 month ago (2009-11-03 03:07:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698