Chromium Code Reviews

Issue 340064: Clobber layout test results at the beginning of each run.... (Closed)

Created:
11 years, 1 month ago by ojan
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Clobber layout test results at the beginning of each run. This should fix issues with the layout_test_results.zip files on the bots have results from other runs, which makes debugging flakiness and other failures harder. Add a flag, clobber-old-results that defaults to false. We'll need to add the flag to the bots, but this will maintain the old behavior for local runs of run_webkit_tests. I'd also be fine not having a flag and always clobbering, but I don't know if people rely on the current behavior for their workflows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30736

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+12 lines, -0 lines)
M webkit/tools/layout_tests/run_webkit_tests.py View 2 chunks +12 lines, -0 lines 1 comment

Messages

Total messages: 2 (0 generated)
ojan
11 years, 1 month ago (2009-11-02 19:07:53 UTC) #1
tony
11 years, 1 month ago (2009-11-02 19:36:54 UTC) #2
LGTM.  The other option would be to just have the buildbot do the clobbering
rather than this script.  I don't have a strong opinion so this seems fine to
me.

http://codereview.chromium.org/340064/diff/1/2
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/340064/diff/1/2#newcode1037
Line 1037: test_dirs = ["LayoutTests", "chrome", "pending"]
Nit: Use () instead of [] to make it immutable.

Powered by Google App Engine