Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 340060: Add lib.target to chrome-wrapper's LD_LIBRARY_PATH. (Closed)

Created:
11 years, 1 month ago by Craig
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add lib.target to chrome-wrapper's LD_LIBRARY_PATH. Needed since r732 of gyp. TEST=Shared build on linux finds libs now without needing to manually adjust LD_LIBRARY_PATH. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30749

Patch Set 1 #

Patch Set 2 : scons still uses lib dir ... keep it around #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/tools/build/linux/chrome-wrapper View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Craig
Please review. Thank you.
11 years, 1 month ago (2009-11-02 17:36:15 UTC) #1
Michael Moss
I wonder if we shouldn't just change gyp to create 'lib.target' as 'lib' (basically the ...
11 years, 1 month ago (2009-11-02 17:42:46 UTC) #2
Michael Moss
By the way, the gyp change that this is needed for is http://code.google.com/p/gyp/source/detail?r=732, not r737. ...
11 years, 1 month ago (2009-11-02 18:54:54 UTC) #3
Michael Moss
Ugh, really adding piman this time.
11 years, 1 month ago (2009-11-02 18:55:19 UTC) #4
pimanttr
LGTM
11 years, 1 month ago (2009-11-02 18:58:19 UTC) #5
pimanttr
On 2009/11/02 17:42:46, Michael Moss wrote: > I wonder if we shouldn't just change gyp ...
11 years, 1 month ago (2009-11-02 18:59:43 UTC) #6
Craig
On 2009/11/02 18:54:54, Michael Moss wrote: > By the way, the gyp change that this ...
11 years, 1 month ago (2009-11-02 19:18:11 UTC) #7
Michael Moss
11 years, 1 month ago (2009-11-02 19:22:58 UTC) #8
OK, LGTM.

Powered by Google App Engine
This is Rietveld 408576698